This repository has been archived by the owner on May 21, 2024. It is now read-only.
API: Add Post API #256
Open
API: Add Post API #256
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akyoto
reviewed
Nov 3, 2020
akyoto
reviewed
Nov 3, 2020
akyoto
reviewed
Nov 3, 2020
| func GetUserFromToken(token uuid.UUID) *arn.User { | ||
| user := &arn.User{} | ||
|
|
||
| for user = range arn.StreamUsers() { |
There was a problem hiding this comment.
Could replace this O(n) loop with an O(1) lookup using a new collection in the DB ("TokenToUser") later on.
Otherwise this can become a huge bottleneck.
There was a problem hiding this comment.
I originally wanted to implement this in a better way but I'm honestly too unfamiliar with nano so I didn't want to touch what I was unsure about.
akyoto
reviewed
Nov 3, 2020
akyoto
reviewed
Nov 3, 2020
akyoto
reviewed
Nov 3, 2020
|
The post API is now technically fully functional, that's why I'm changing the PR status from "draft" to "open". There are however 3 important things that should be addressed before merging this PR:
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📢 Type of change
📜 Description
This is a long-term draft for a Post API. The current ETA is late 2020
💡 Motivation and Context
Currently something I'm missing the most [Besides Manga support] is being able to integrate/update notify.moe through third-party applications. This draft plans to add all features needed to allow exactly that.
🔮 Next steps
Progress will always be updated on my forks project board: https://github.com/tumGER/notify.moe/projects/1