This repository has been archived by the owner on May 21, 2024. It is now read-only.
Different algo animelist #186
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
soulcramer
force-pushed
the
different_algo_animelist
branch
3 times, most recently
from
2f92ac4 to
9482167
Compare
soulcramer
force-pushed
the
different_algo_animelist
branch
from
9482167 to
cb11925
Compare
soulcramer
force-pushed
the
different_algo_animelist
branch
from
cb11925 to
94b8abe
Compare
|
I've used the selector to display the different sort algorithm to the user in the explore page and the editor anime section. I didn't found a decent way to display these sorts algorithm for the animelist page yet. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a PR aimed to added multiple sort strategies on animelist #160.
I had no clear idea on how to let the user select which sort he would want to use so I've just added a query parameter to the animelist route so it can be tested.
The design of the selection of the sorting algorithm can be tagged as a
good first issuefor new contributors 🤔?