Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Experimental: Add CGS and FPS unit systems #630

Closed
wants to merge 1 commit into from

Conversation

angularsen
Copy link
Owner

@angularsen angularsen commented Mar 4, 2019

Inspired by the previous PR, I figured adding these CGS and FPS unit systems would be a breeze.
It did not take long to stop me in my tracks. I truly am lost on what units to designate the 7 base units for CGS and FPS unit systems. Do you have some ideas on how to proceed here?

I couldn't find much information about the units and it almost seems like there is no 1:1 mapping between SI base units concept and CGS/FPS. For instance, in CGS there is a table for converting from SI electric units to CGS units in ESU/EMU/Gauss systems - so maybe CSG is just a group of systems sharing those three base units and ESU/EMU/Gauss are really the systems we should consider adding instead?

https://no.wikipedia.org/wiki/CGS-systemet (Norwegian wiki)

I don't know. Maybe these systems are so old no one will care about them being available either. I'm just eager to add something more than just SI to help showcase the value of various unit systems, which is yet a fairly abstract concept to me.

Update:
After maturing this thought a bit, I think our current UnitSystem design needs a little bit of rethink. It is currently an SI unit system, with 7 SI base units. Other unit systems don't define all those units or define entirely different units. See #651 for discussion.

@angularsen angularsen requested a review from tmilnthorp March 4, 2019 21:45
@tmilnthorp
Copy link
Collaborator

Seems they aren't specified! I could relax the fully defined for UnitSystems. But not all conversions will succeed.

@angularsen
Copy link
Owner Author

Should also look into adding British Engineering units and English Engineering units, as a proof of concept.

@angularsen
Copy link
Owner Author

angularsen commented Aug 5, 2019

Closing this for now until #651 discussion moves forward.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants