v6-Electric #1467
Open
v6-Electric #1467
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rearranged some of the electrical units, all with the prefix "Electric", and labeled the following classes as obsolete: * ApparentEnergy -> ElectricApparentEnergy * ApparentPower -> ElectricApparentPower * Capacitance -> ElectricCapacitance * ReactiveEnergy -> ElectricReactiveEnergy * ReactivePower -> ElectricReactivePower Added classes for ElectricReactance and ElectricSusceptance. Labeled ElectricPotentialAc and ElectricPotentialDc as obsolete per discussion. Labeled ElectricAdmittance as obsolete due to it being a complex number. Revised ObsoleteText messages to be more useful. Added correct testing code. Added ElectricImpedance class; even though it's a complex number, it "rounds out" the other five units of: * Admittance * Conductance * Reactance * Resistance * Susceptance
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rearranged some of the electrical units, all with the prefix "Electric", and labeled the following classes as obsolete:
Added correct testing code.
Added ElectricImpedance class; even though it's a complex number, it "rounds out" the other five units of: