Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix wrong SolarMass abbreviation #1125

Merged
merged 3 commits into from
Sep 2, 2022
Merged

Conversation

Brunni
Copy link
Contributor

@Brunni Brunni commented Aug 29, 2022

@tmilnthorp
Copy link
Collaborator

tmilnthorp commented Aug 29, 2022

Interesting! This would be a breaking parse change. We should leave the old incorrect string as an abbreviation (non default), so that parsing the incorrect symbol will work until a major version. Can we mark abbreviation strings as obsolete @angularsen?

@angularsen
Copy link
Owner

Interesting! This would be a breaking parse change. We should leave the old incorrect string as an abbreviation (non default), so that parsing the incorrect symbol will work until a major version. Can we mark abbreviation strings as obsolete @angularsen?

I don't think so, we will just have to mark it as a breaking change in #982 and document it, I guess.

@angularsen
Copy link
Owner

@Brunni If you can add the correct one first in the array, and keep the old one as second item in the array, then parsing won't break, while ToString() will prefer the first one. Then we can merge this.

@codecov
Copy link

codecov bot commented Aug 31, 2022

Codecov Report

Merging #1125 (ccb54d8) into master (77b1ef2) will not change coverage.
The diff coverage is 100%.

@@          Coverage Diff           @@
##           master   #1125   +/-   ##
======================================
  Coverage      85%     85%           
======================================
  Files         322     322           
  Lines       52322   52322           
======================================
  Hits        44894   44894           
  Misses       7428    7428           
Impacted Files Coverage Δ
UnitsNet/GeneratedCode/Quantities/Mass.g.cs 91% <100%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@angularsen angularsen changed the title Fix wrong solarMass abbreviation Fix wrong SolarMass abbreviation Sep 2, 2022
@angularsen angularsen merged commit 224d649 into angularsen:master Sep 2, 2022
@angularsen
Copy link
Owner

Thank you! Nuget should be out in the next hour.

Release UnitsNet/4.145.0 · angularsen/UnitsNet

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants