Merge pull request #175 from psliwka/psliwka/fix-homeshick.fish

Fix argument testing in homeshick.fish
andsens · Feb 23, 2018 · 0bebb26 · 0bebb26
2 parents 680252e + 83b05a7
commit 0bebb26
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 1 deletion.
diff --git a/homeshick.fish b/homeshick.fish
@@ -4,7 +4,7 @@
 # "homeshick cd CASTLE" to enter a castle.
 
 function homeshick
-	if test \( (count $argv) = 2 -a $argv[1] = "cd" \)
+	if test \( (count $argv) = 2 -a "$argv[1]" = "cd" \)
 		cd "$HOME/.homesick/repos/$argv[2]"
 	else if set -q HOMESHICK_DIR
 		eval $HOMESHICK_DIR/bin/homeshick (string escape -- $argv)

diff --git a/test/suites/misc.bats b/test/suites/misc.bats
@@ -30,3 +30,11 @@ load ../helper
 	run grep -q 'nn$' <<<"$output"
 	[ $status -eq 1 ]
 }
+
+@test 'fish function should not print errors when invoked without arguments' {
+	[ "$(type -t fish)" = "file" ] || skip "fish not installed"
+	cmd="source "$HOMESHICK_FN_SRC_FISH"; and $HOMESHICK_FN"
+	local stderr
+	stderr=$( fish <<< "$cmd" 2>&1 >/dev/null )
+	[ -z "$stderr" ]
+}