Revert "Updated path to jupyter notebooks"

[andeplane]

User description

Reverts #122

---

PR Type

enhancement, configuration changes

---

Description

• Reverted the path for Jupyter notebooks in the Notebook.tsx component, updating the URL path from jupyterlite to jupyter.
• Updated the JupyterLite build output directory in the GitHub Actions workflow from public/jupyterlite to public/jupyter.
• Modified the README to reflect the updated JupyterLite build command, changing the output directory path.

---

Changes walkthrough 📝

	Relevant files
Enhancement	Notebook.tsx Revert Jupyter notebook path and update URL                            src/containers/Notebook.tsx Reverted the path for Jupyter notebooks in the URL. Updated the URL path from jupyterlite to jupyter. Added semicolons for consistent code formatting. +5/-5
Configuration changes	deploy.yaml Update JupyterLite build output directory                                .github/workflows/deploy.yaml Changed the output directory for JupyterLite build. Updated path from public/jupyterlite to public/jupyter. +1/-1
Documentation	README.md Update JupyterLite build command in README                              README.md Updated JupyterLite build command in documentation. Changed output directory path in the example command. +1/-1

---

💡 PR-Agent usage: Comment /help "your question" on any pull request to receive relevant information

[qodo-merge-pro]

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

⏱️ Estimated effort to review: 2 🔵🔵⚪⚪⚪

🧪 No relevant tests

🔒 No security concerns identified

⚡ Recommended focus areas for review Path Consistency Ensure that the path change from 'jupyterlite' to 'jupyter' is consistent across the entire codebase and configuration files. Build Output Verification Verify that the new output directory 'public/jupyter' is correctly referenced in all deployment and serving configurations. Documentation Update Ensure that all references to JupyterLite paths in the documentation are updated to reflect the new 'jupyter' path.

[qodo-merge-pro]

PR Code Suggestions ✨

Explore these optional code suggestions:

Category	Suggestion	Score
Possible issue	Add a null check for a potentially undefined property to prevent runtime errors Consider adding a check for the existence of simulation.id before using it in the string interpolation. This can prevent potential runtime errors if simulation.id is undefined. src/containers/Notebook.tsx [7-9] -if (simulation?.analysisScript) { +if (simulation?.analysisScript && simulation.id) { const analysisScriptPath = `${simulation.id}/${simulation.analysisScript}`; notebookUrl = `/atomify/jupyter/lab/index.html?path=${analysisScriptPath}`; } Apply this suggestion Suggestion importance[1-10]: 8 Why: Adding a null check for simulation.id is a crucial improvement that prevents potential runtime errors. This suggestion enhances the robustness of the code by ensuring that the property exists before using it in string interpolation.	8
Enhancement	Simplify string construction using template literals and conditional expressions Consider using template literals for the notebookUrl string to improve readability and maintainability. This approach allows for easier string interpolation and reduces the need for string concatenation. src/containers/Notebook.tsx [6-9] -let notebookUrl = `/atomify/jupyter/lab/index.html?path=analyze.ipynb`; -if (simulation?.analysisScript) { - const analysisScriptPath = `${simulation.id}/${simulation.analysisScript}`; - notebookUrl = `/atomify/jupyter/lab/index.html?path=${analysisScriptPath}`; -} +let notebookUrl = `/atomify/jupyter/lab/index.html?path=${simulation?.analysisScript ? `${simulation.id}/${simulation.analysisScript}` : 'analyze.ipynb'}`; Apply this suggestion Suggestion importance[1-10]: 7 Why: This suggestion improves code readability and maintainability by using template literals and conditional expressions, which simplifies the logic for constructing the notebookUrl. It is a valid enhancement that aligns with modern JavaScript practices.	7
Best practice	Extract repeated URL into a constant for improved maintainability Consider extracting the base URL /atomify/jupyter/lab/index.html into a constant at the top of the component. This improves maintainability by centralizing the URL definition and makes it easier to update if needed. src/containers/Notebook.tsx [6-9] -let notebookUrl = `/atomify/jupyter/lab/index.html?path=analyze.ipynb`; +const BASE_NOTEBOOK_URL = '/atomify/jupyter/lab/index.html'; +let notebookUrl = `${BASE_NOTEBOOK_URL}?path=analyze.ipynb`; if (simulation?.analysisScript) { const analysisScriptPath = `${simulation.id}/${simulation.analysisScript}`; - notebookUrl = `/atomify/jupyter/lab/index.html?path=${analysisScriptPath}`; + notebookUrl = `${BASE_NOTEBOOK_URL}?path=${analysisScriptPath}`; } Apply this suggestion Suggestion importance[1-10]: 6 Why: Extracting the base URL into a constant improves maintainability by centralizing the URL definition, making future updates easier. While not critical, it is a good practice that enhances code organization.	6

💡 Need additional feedback ? start a PR chat