Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ad7191 #598

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Conversation

Kantipudi-Supriya
Copy link

  1. Modified to_volts so that it gives the correct value for both
    unipolar and bipolar mode

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How has this been tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

Test Configuration:

  • Hardware:SDP-K1,EVAL-AD7191
  • OS:STM32

Documentation

If this is a new feature or example please mention or link any documentation. All new hardware interface classes require documentation.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have signed off all commits and they contain "Signed-off by: "
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

1) Modified to_volts so that it gives the correct value for both
   unipolar and bipolar mode

Signed-off-by: Kantipudi-Supriya <[email protected]>
@Kantipudi-Supriya
Copy link
Author

Is there any review comments here

@tfcollins tfcollins self-requested a review September 18, 2024 21:43
@tfcollins
Copy link
Collaborator

  • Please address lint issues
  • Add ad7191 to supported_parts.md

Copy link
Collaborator

@tfcollins tfcollins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Please address lint issues
  • Add ad7191 to supported_parts.md

1)Added the ad7191 to the supported_parts.md

Signed-off-by: Kantipudi-Supriya <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants