Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(retry): miscellaneous improvements to the default retry mechanisms #120

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

kelvin-lu
Copy link
Contributor

Summary

Props to @yuhao900914 (and I assume @dantetam in collaboration writing the Java SDK) for doing a critical reading of the logic in the retry mechanisms.

Fixes a couple of logical bugs that could result in errors down the line:

  • Fixes an issue where the lastRetry flag is not computed correctly and can cause events to be retried more than necessary
  • Fixes an issue where the wrong # of events are counted when removing due to 400 issues
  • Makes an improvement to the logic checking of when tot stop retry loops

Checklist

  • Does your PR title have the correct title format?
  • Does your PR have a breaking change?:

@ajhorst
Copy link
Contributor

ajhorst commented Jul 30, 2021

@kelvin-lu is this PR still valid?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants