Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/219 update documentation #240

Merged
merged 2 commits into from
Feb 6, 2024
Merged

Conversation

M-HRL
Copy link
Contributor

@M-HRL M-HRL commented Feb 6, 2024

@M-HRL M-HRL requested review from Gnagniko and irhox February 6, 2024 10:53
@M-HRL M-HRL self-assigned this Feb 6, 2024
@M-HRL
Copy link
Contributor Author

M-HRL commented Feb 6, 2024

Please do ignore the changes from the other PR, but so we do not need merging the main.

@M-HRL M-HRL marked this pull request as ready for review February 6, 2024 11:43
Gnagniko
Gnagniko previously approved these changes Feb 6, 2024
Copy link
Collaborator

@Gnagniko Gnagniko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@M-HRL M-HRL dismissed Gnagniko’s stale review February 6, 2024 12:49

The merge-base changed after approval.

@Gnagniko Gnagniko self-requested a review February 6, 2024 12:51
Gnagniko
Gnagniko previously approved these changes Feb 6, 2024
Copy link
Collaborator

@Gnagniko Gnagniko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@M-HRL M-HRL dismissed Gnagniko’s stale review February 6, 2024 12:56

The merge-base changed after approval.

@Gnagniko Gnagniko self-requested a review February 6, 2024 12:59
Gnagniko
Gnagniko previously approved these changes Feb 6, 2024
@M-HRL M-HRL dismissed Gnagniko’s stale review February 6, 2024 13:01

The merge-base changed after approval.

@Gnagniko Gnagniko self-requested a review February 6, 2024 13:26
@M-HRL M-HRL merged commit b24b14b into main Feb 6, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants