GTest improvements #563
Open
GTest improvements #563
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Port ament#543 to gmock Signed-off-by: Andrej Valek <[email protected]>
Instead of always compiling own gmock/gtestG, try to use GTest targets from FindGTest cmake config, but without changing the old behavior. Signed-off-by: Andrej Valek <[email protected]>
I don't think this PR relates to this issue. Is there another one you meant to link? |
sloretz
reviewed
Dec 6, 2024
Comment on lines
+71
to
+78
| else() | ||
| # try to find and use gmock from GTest | ||
| find_package(GTest QUIET) | ||
| if(GTest_FOUND) | ||
| set(GMOCK_FOUND TRUE) | ||
| set(GMOCK_LIBRARIES GTest::gmock) | ||
| set(GMOCK_MAIN_LIBRARIES GTest::gmock_main) | ||
| endif() |
There was a problem hiding this comment.
This looks a little strange to me. Mind explaining when we can assume GTest will provide targets for gmock prefixed with GTest::?
There was a problem hiding this comment.
Because it's in the documentation? :)
https://cmake.org/cmake/help/latest/module/FindGTest.html#imported-targets
Ah, I see. I was thinking, that there was a missing option to add external gmock library. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ament_cmake_gmock-extrasgtestorgmocktargets fromGTest