change: Remove throw from local task cancellation #856
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #856 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 129 129
Lines 8519 8532 +13
Branches 1905 1908 +3
=========================================
+ Hits 8519 8532 +13 ☔ View full report in Codecov by Sentry. |
speller26
previously approved these changes
Jan 20, 2024
AbeCoull
reviewed
Jan 26, 2024
| Since this class is instantiated with the results, there is nothing to cancel. Attempting | ||
| to cancel an already completed task is not an error. | ||
| """ | ||
| pass |
There was a problem hiding this comment.
I have mixed feelings about using pass here. What would your thoughts be if we instead used a log line indicating local tasks are already complete on instantiation or some better worded statement?
AbeCoull
reviewed
Jan 26, 2024
| @@ -42,8 +42,12 @@ def id(self) -> str: | |||
| return str(self._id) | |||
|
|
|||
| def cancel(self) -> None: | |||
| """Cancel the quantum task.""" | |||
| raise NotImplementedError("Cannot cancel completed local task") | |||
| """Attempt to cancel the quantum task. | |||
There was a problem hiding this comment.
nit: if we are always using pass and the task is expected to be complete, attempt has the wrong implication.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Cancellation of AWS tasks is a best effort process. Attempting to cancel an AWS task which has already completed is not an error. This change will make local tasks behave the same way.
Testing done:
Merge Checklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.General
Tests
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.