Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update numpy random function to use a generator #274

Merged
merged 1 commit into from
Nov 22, 2024
Merged

Conversation

AbeCoull
Copy link
Contributor

Issue #, if available:

Description of changes:

Recommendation from https://numpy.org/doc/stable/reference/random/generated/numpy.random.choice.html

Testing done:

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

General

Tests

  • I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • I have checked that my tests are not configured for a specific region or account (if appropriate)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@AbeCoull AbeCoull requested a review from speller26 November 21, 2024 22:09
Copy link

codecov bot commented Nov 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (a9808f3) to head (5ac1bdb).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##              main      #274    +/-   ##
==========================================
  Coverage   100.00%   100.00%            
==========================================
  Files           48        48            
  Lines         3802      3804     +2     
  Branches       930       396   -534     
==========================================
+ Hits          3802      3804     +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@AbeCoull AbeCoull marked this pull request as ready for review November 21, 2024 22:16
@AbeCoull AbeCoull requested a review from a team as a code owner November 21, 2024 22:16
@AbeCoull AbeCoull requested a review from jheckey November 22, 2024 14:39
@AbeCoull AbeCoull merged commit fd1ed94 into main Nov 22, 2024
33 checks passed
@AbeCoull AbeCoull deleted the np_random branch November 22, 2024 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants