Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

infra: drop support for Python 3.8 #211

Merged
merged 1 commit into from
Oct 10, 2023
Merged

infra: drop support for Python 3.8 #211

merged 1 commit into from
Oct 10, 2023

Conversation

AbeCoull
Copy link
Contributor

@AbeCoull AbeCoull commented Oct 3, 2023

Issue #, if available:

Description of changes:

Testing done:

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

General

Tests

  • I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • I have checked that my tests are not configured for a specific region or account (if appropriate)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@codecov
Copy link

codecov bot commented Oct 3, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (1044c34) 100.00% compared to head (3eb6e71) 100.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##              main      #211    +/-   ##
==========================================
  Coverage   100.00%   100.00%            
==========================================
  Files           48        48            
  Lines         3753      3753            
  Branches       542       910   +368     
==========================================
  Hits          3753      3753            

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@AbeCoull AbeCoull marked this pull request as ready for review October 10, 2023 19:04
@AbeCoull AbeCoull requested a review from a team as a code owner October 10, 2023 19:04
@AbeCoull AbeCoull merged commit a931357 into main Oct 10, 2023
31 checks passed
@AbeCoull AbeCoull deleted the py_39 branch October 10, 2023 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants