test/e2e/s3: attach stdout & stderr to exec() errors

It may not be immediately obvious that stdout and stderr are actually available when a call to `child_process.exec()` fails. Attaching them here should bring attention to this, and aid future debugging.
alxndrsn · Dec 10, 2024 · cdd63d6 · cdd63d6
1 parent 4355d9e
commit cdd63d6
Showing 1 changed file with 6 additions and 2 deletions.
diff --git a/test/e2e/s3/test.js b/test/e2e/s3/test.js
@@ -407,8 +407,12 @@ function cli(cmd) {
   const env = { ..._.pick(process.env, 'PATH'), NODE_CONFIG_ENV:'s3-dev' };
 
   const promise = new Promise((resolve, reject) => {
-    const child = exec(cmd, { env, cwd:'../../..' }, (err, stdout) => {
-      if (err) return reject(err);
+    const child = exec(cmd, { env, cwd:'../../..' }, (err, stdout, stderr) => {
+      if (err) {
+        err.stdout = stdout;
+        err.stderr = stderr;
+        return reject(err);
+      }
 
       const res = stdout.toString().trim();
       log.debug('cli()', 'returned:', res);