Fix create asset worker to send updates for PolicyGroup #8357
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Whilst the draft update call to publishing api also triggers an asset manager call for the entire attachable (see listener in edition_services.rb), the publishing api call does not get triggered for policy group. Asset manager updates end up not being made. We are now specifically making this call for all AttachmentDatas that belong to a PolicyGroup. Co-authored-by: Syed Ali <[email protected]> Co-authored-by: Iris Lau <[email protected]>
lauraghiorghisor-tw
force-pushed
the
fix-asset-manmager-updates-for-all-attachables
branch
from
7b1b50d to
579b22f
Compare
syed-ali-tw
approved these changes
Oct 11, 2023
lauraghiorghisor-tw
deleted the
fix-asset-manmager-updates-for-all-attachables
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Whilst the draft update call to publishing api also triggers an asset manager call for the entire attachable (see listener in edition_services.rb), the publishing api call does not get triggered for policy group. Asset manager updates end up not being made.
We are now specifically making this call for all AttachmentDatas that belong to a PolicyGroup.
Trello card