Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove references to slug on document filter #8350

Merged
merged 1 commit into from
Oct 11, 2023

Conversation

beccapearce
Copy link
Contributor

The word slug is not well used by publishers and it is usually the same as the page title. It will be less confusing to users if we just use one.

trello card: https://trello.com/c/Uttw5Q63
Before:
image

After:
image

The word slug is not well used by publishers and it is usually the same as the page title. It will be less confusing to users if we just use one.

trello card: https://trello.com/c/Uttw5Q63
Copy link
Contributor

@davidgisbey davidgisbey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

Just a couple of questions

It's still title or slug for statistics announcements. Do you want to update that to or is that out of scope?

The edition filter will still match on title and slug. Do we want to leave that in place?

@beccapearce
Copy link
Contributor Author

I think it makes sense to update it for both to keep it consistent. but maybe I should double check that that is correct.

And yes The behaviour should stay the same and match on both, people still search by slug so i think we should keep that

@beccapearce
Copy link
Contributor Author

Just got confirmation that we want to remove all the slug references so it should be removed for stats announcements too :)

@beccapearce beccapearce merged commit 03f1e5d into main Oct 11, 2023
10 checks passed
@beccapearce beccapearce deleted the remove-slug-from-filter-label branch October 11, 2023 08:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants