Fix several errors relating to date validation #8345
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Includes fixes for the following issues: - When the year was nil, a NoMethodError was being thrown because we were attempting to call "zero?" on nil. We're now rescuing from the NoMethodError and marking the date invalid - Entering a negative month value would trigger a MultiparameterAssigmentError, because Ruby Date constructor allows months to be set using a negative offset but Rails date assignment does not
ryanb-gds
force-pushed
the
fix-invalid-date-errors
branch
from
c7f62f9 to
51afa2f
Compare
davidgisbey
reviewed
Oct 10, 2023
| raise TypeError if date[1].zero? | ||
|
|
||
| # Rails does not accept negative month values, but the Date constructor does | ||
| raise TypeError if (date[2]).negative? |
There was a problem hiding this comment.
does the date constructor handle negative values for years and days then?
There was a problem hiding this comment.
Well, a negative year is legitimate (BC years), and yes it does prevent negative days: https://docs.ruby-lang.org/en/master/Date.html#method-c-new
There was a problem hiding this comment.
cool thanks. I suspect the person putting in negative values was purposefully doing to try and break it 😂
LGTM!
davidgisbey
approved these changes
Oct 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Includes fixes for the following issues: