Moving preview path to asset domain #8337
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ssue Mission is to be able to move it to relative path so nightly data copy dont copy the wrong hard coded production urls to lower environment. But moving to relative path is fairly complicated and requires adding logic to allow routing from "gov.uk" domain to asset domain with "/media" path. To allow fixing of some of csv's not working in prod. We are moving things to hard-coded asset path.(This is also already the case for other attachment types).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is to allow csv url paths to be published with asset domain path, to try and fix the csv preview issue.
Mission is to be able to move it to relative path so nightly data copy dont copy the wrong hard coded production urls to lower environment. But moving to relative path is fairly complicated and requires adding logic to allow routing from "gov.uk" domain to asset domain with "/media" path.
To allow fixing of some of csv's not working in prod. We are moving things to hard-coded asset path.(This is also already the case for other attachment types).
Trello