Fix test regarding to GOVUK_ASSET_ROOT #8259
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yuetylauiris
force-pushed
the
fix-test-regarding-to-govuk_asset_root
branch
2 times, most recently
from
cb7647e to
95a5b43
Compare
GOVUK_ASSET_ROOT has been specified in govuk-docker since alphagov/govuk-docker@854556a. Thus local environment no longer resolve to default of "https://static.test.gov.uk" and changes the behavior of these tests.
yuetylauiris
force-pushed
the
fix-test-regarding-to-govuk_asset_root
branch
from
95a5b43 to
636adfb
Compare
|
related trello card: https://trello.com/c/jt6xWPku/189-fix-test-regarding-to-govukassetroot |
tunylund
approved these changes
Sep 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GOVUK_ASSET_ROOT has been specified in govuk-docker since this commit that fixes static asset url in dev env. Thus local environment no longer resolve to default of "https://static.test.gov.uk" and changes the behavior of these tests.
Follow these steps if you are doing a Rails upgrade.