Remove placeholder logic #8251
Merged
Remove placeholder logic #8251
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We were previously sending some content items to Publishing API with a schema type prefixed `placeholder_` to indicate that content item was still rendered by Whitehall. This is no longer the case, so we can remove that logic. The `GenericEditionPresenter` is used solely in tests, reverting this to use a generic `placeholder` schema as the logic will be removed from Publishing API in alphagov/publishing-api#2504. This will need to be updated again when the `placeholder` schema is completely removed.
jkempster34
approved these changes
Sep 14, 2023
There was a problem hiding this comment.
You mention that this will need updating further once the placeholder content schema is removed, do you mean beyond this? #8252
Nope. Other than removing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were previously sending some content items to Publishing API with a schema type prefixed
placeholder_to indicate that content item was still rendered by Whitehall.This is no longer the case, so we can remove that logic.
The
GenericEditionPresenteris used solely in tests, reverting this to use a genericplaceholderschema as the logic will be removed from Publishing API in alphagov/publishing-api#2504.This will need to be updated again when the
placeholderschema is completely removed.Trello card
Follow these steps if you are doing a Rails upgrade.