changed the add documents and reorder links from p tags to list tags …

…as these are more semantically and stylistally correct
alphagov · Oct 10, 2023 · 1a1679c · 1a1679c
1 parent b8e5c7a
commit 1a1679c
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 12 deletions.
diff --git a/app/assets/stylesheets/admin/views/_document-collection-group-memberships-index.scss b/app/assets/stylesheets/admin/views/_document-collection-group-memberships-index.scss
@@ -15,9 +15,10 @@
   display: flex;
   align-items: center;
 
-  & > p:first-child {
+  & > li:first-child {
     @include govuk-responsive-padding(2, "right");
     @include govuk-responsive-margin(2, "right");
     border-right: 1px solid $govuk-border-colour;
   }
 }
+
diff --git a/app/views/admin/document_collection_group_memberships/index.html.erb b/app/views/admin/document_collection_group_memberships/index.html.erb
@@ -26,17 +26,15 @@
             text: "Documents",
             margin_bottom: 6,
           } %>
-
-          <div class="app-view-document-collection-group-memberships-index__heading-links">
-            <p class="govuk-body govuk-!-text-align-right">
+          <ul class="govuk-list app-view-document-collection-group-memberships-index__heading-links">
+            <li>
               <%= link_to "Add document", admin_document_collection_group_search_options_path(@collection, @group), class: "govuk-link" %>
-            </p>
+            </li>
 
-            <p class="govuk-body govuk-!-text-align-right">
+            <li>
               <%= link_to "Reorder document", reorder_admin_document_collection_group_document_collection_group_memberships_path(@collection, @group), class: "govuk-link" %>
-            </p>
-          </div>
-
+            </li>
+          </ul>
         </div>
       </div>
     <% else %>
@@ -47,9 +45,11 @@
             margin_bottom: 6,
           } %>
 
-          <p class="govuk-body govuk-!-text-align-right">
-            <%= link_to "Add document", admin_document_collection_group_search_options_path(@collection, @group), class: "govuk-link" %>
-          </p>
+          <ul class="govuk-list govuk-body govuk-!-text-align-right">
+            <li>
+              <%= link_to "Add document", admin_document_collection_group_search_options_path(@collection, @group), class: "govuk-link" %>
+            </li>
+          </ul>
         </div>
       </div>
     <% end %>