Allow worker to depend on Rails environment #46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We've decided that we won't extract the document sync worker from the Rails application for the sake of convenience and avoiding having several repos with only slightly different dependencies and configuration. - Remove custom logger from `DocumentSyncWorker` and just use Rails logger instead - Allow Rake task to depend on Rails environment to make sure `govuk_app_config` is properly initialised throughout
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've decided that we won't extract the document sync worker from the Rails application for the sake of convenience and avoiding having several repos with only slightly different dependencies and configuration.
DocumentSyncWorkerand just use Rails logger insteadgovuk_app_configis properly initialised throughout