Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Time.parse for document timestamps #39

Merged
merged 1 commit into from
Oct 6, 2023
Merged

Use Time.parse for document timestamps #39

merged 1 commit into from
Oct 6, 2023

Conversation

csutter
Copy link
Contributor

@csutter csutter commented Oct 6, 2023

Rubocop prefers Rails's Time.zone.parse over Ruby's Time.parse, but this is actually counterproductive here as the public_updated_at timestamp contains a timezone which shouldn't get lost (and using the Rails zoned time couples us to Rails).

Rubocop prefers Rails's `Time.zone.parse` over Ruby's `Time.parse`, but
this is actually counterproductive here as the `public_updated_at`
timestamp contains a timezone which shouldn't get lost (and using the
Rails zoned time couples us to Rails).
@csutter csutter merged commit 251174d into main Oct 6, 2023
3 checks passed
@csutter csutter deleted the time branch October 6, 2023 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant