Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor document syncing #313

Merged
merged 1 commit into from
Aug 7, 2024
Merged

Refactor document syncing #313

merged 1 commit into from
Aug 7, 2024

Conversation

csutter
Copy link
Contributor

@csutter csutter commented Aug 6, 2024

Extract common logic into Operation from subclasses, so they can focus on the unique behaviour for each respective operation.

kevindew
kevindew approved these changes Aug 7, 2024
View reviewed changes
Copy link
Member

@kevindew kevindew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good, nice job combining that shared code together. I just have a non-blocking suggestion about the interface to the syncing.

app/services/discovery_engine/sync/delete.rb Outdated Show resolved Hide resolved
@csutter
Refactor document syncing
4391ccf 
Extract common logic into `Operation` from subclasses, so they can focus
on the unique behaviour for each respective operation.
@csutter csutter merged commit 3438397 into main Aug 7, 2024
8 checks passed
@csutter csutter deleted the sync-refac branch August 7, 2024 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kevindew kevindew kevindew approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@csutter @kevindew