Decouple repositories from PublishingEventPipeline
#21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now that we have moved the repositories out into their own module, it doesn't necessarily make sense for them to know about internals of the pipeline module. If we assume that a repository's knowledge about a "document"/"indexable thing" can be limited to an ID, some metadata, and some unstructured content, we can get rid of the `Document` model and thus a cross-module boundary dependency entirely. - Remove `PublishingEventPipeline::Document` class - Make repositories take explicit bare arguments for metadata and content
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that we have moved the repositories out into their own module, it doesn't necessarily make sense for them to know about internals of the pipeline module. If we assume that a repository's knowledge about a "document"/"indexable thing" can be limited to an ID, some metadata, and some unstructured content, we can get rid of the
Documentmodel and thus a cross-module boundary dependency entirely.PublishingEventPipeline::Documentclass