Merge pull request #71 from alphagov/string-payload

Coerce documents' `payload_version` to int

lib/document_sync_worker/document/base.rb

@@ -18,7 +18,7 @@ def content_id
 
       # The payload version of the document.
       def payload_version
-        document_hash.fetch("payload_version")
+        document_hash.fetch("payload_version").to_i
       end
 
     private

spec/lib/document_sync_worker/document/publish_spec.rb

@@ -6,7 +6,7 @@
   end
 
   let(:content_id) { "123" }
-  let(:payload_version) { 1 }
+  let(:payload_version) { "1" }
   let(:document_type) { "press_release" }
   let(:document_hash) do
     {
@@ -24,7 +24,7 @@
 
   describe "#payload_version" do
     it "returns the payload_version from the document hash" do
-      expect(document.payload_version).to eq(payload_version)
+      expect(document.payload_version).to eq(1)
     end
   end
 
@@ -522,7 +522,7 @@
       document.synchronize_to(repository)
 
       expect(repository).to have_received(:put).with(
-        content_id, document.metadata, content: document.content, payload_version:
+        content_id, document.metadata, content: document.content, payload_version: 1
       )
     end
   end

spec/lib/document_sync_worker/document/unpublish_spec.rb

@@ -6,7 +6,7 @@
   end
 
   let(:content_id) { "123" }
-  let(:payload_version) { 1 }
+  let(:payload_version) { "1" }
   let(:document_type) { "gone" }
   let(:document_hash) do
     {
@@ -24,15 +24,15 @@
 
   describe "#payload_version" do
     it "returns the payload_version from the document hash" do
-      expect(document.payload_version).to eq(payload_version)
+      expect(document.payload_version).to eq(1)
     end
   end
 
   describe "#synchronize_to" do
     it "deletes the document from the repository" do
       document.synchronize_to(repository)
 
-      expect(repository).to have_received(:delete).with(content_id, payload_version:)
+      expect(repository).to have_received(:delete).with(content_id, payload_version: 1)
     end
   end
 end