186049138 - Update awscli image to include openssh #309
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Description: - paas-bootstrap's create-bosh-concourse [pipeline](https://github.com/alphagov/paas-bootstrap/blob/9061827f4c35ac844d1e4dfdefb2eb3e167cf13f/concourse/pipelines/create-bosh-concourse.yml#L645) installs openssh using apk but it should be bundled as part of the docker image - Bundle openssh into the awscli docker image
nimalank7
deleted the
186049138-Update-awscli-image-to-include-openssh
branch
corlettb
reviewed
Oct 19, 2023
| @@ -7,6 +7,7 @@ RUN apk add --no-cache \ | |||
| less>=590-r0 \ | |||
| python3~3.10 \ | |||
| py3-pip~22 \ | |||
| openssh \ | |||
There was a problem hiding this comment.
I know you are just moving things from paas-bootstrap. However this feels like it should be 'openssh-client'. I don't think we need the server packages.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
How to review
create-bosh-concoursecreate-cloudfoundry