GOVUKAPP-1009 Onboarding screens missed when using swipe to navigate #152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gclssvglx
previously approved these changes
Dec 13, 2024
|
gclssvglx
approved these changes
Dec 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Onboarding screens missed when using swipe to navigate
Cause
Focus of page title labels was being requested on instances of further pages than the current one causing the pager to skip to the further pages
Resolution
Only request focus of page title on current page
JIRA ticket(s)
Figma
Before
GOVUKAPP-1009.Before.fix.mov
After
GOVUKAPP-1009.After.fix.mov