Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GOVUKAPP-1011: PYV Edit Selection Bug #151

Merged
merged 1 commit into from
Dec 12, 2024
Merged

GOVUKAPP-1011: PYV Edit Selection Bug #151

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion feature/visited/src/main/kotlin/uk/govuk/app/visited/ui/EditVisitedScreen.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,7 @@
package uk.govuk.app.visited.ui

import androidx.compose.foundation.clickable
import androidx.compose.foundation.interaction.MutableInteractionSource
import androidx.compose.foundation.layout.Box
import androidx.compose.foundation.layout.Column
import androidx.compose.foundation.layout.Row
Expand All @@ -21,6 +23,7 @@ import androidx.compose.runtime.Composable
import androidx.compose.runtime.LaunchedEffect
import androidx.compose.runtime.collectAsState
import androidx.compose.runtime.getValue
import androidx.compose.runtime.remember
import androidx.compose.ui.Alignment
import androidx.compose.ui.Modifier
import androidx.compose.ui.draw.drawBehind
Expand Down Expand Up @@ -179,11 +182,18 @@ private fun CheckableExternalLinkListItem(
) {
CardListItem(
modifier = modifier,
onClick = { onSelect(item.title, item.url) },
isFirst = isFirst,
isLast = isLast
) {
val interactionSource = remember { MutableInteractionSource() }
Row(
modifier = Modifier
.clickable(
interactionSource = interactionSource,
indication = null
){
onSelect(item.title, item.url)
},
verticalAlignment = Alignment.CenterVertically
) {
Column(
Expand Down
Loading