GOVUKAPP-994 Talkback reads out wrong item #149
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…probably flaky solution
# Conflicts: # design/src/main/kotlin/uk/govuk/app/design/ui/component/Header.kt
TimGJD
commented
Dec 11, 2024
feature/visited/src/main/kotlin/uk/govuk/app/visited/ui/VisitedScreen.kt
Show resolved
Hide resolved
feature/visited/src/main/kotlin/uk/govuk/app/visited/VisitedViewModel.kt
Outdated
Show resolved
Hide resolved
gclssvglx
previously approved these changes
Dec 11, 2024
davidc-gds
reviewed
Dec 12, 2024
design/src/main/kotlin/uk/govuk/app/design/ui/component/Header.kt
Outdated
Show resolved
Hide resolved
feature/visited/src/main/kotlin/uk/govuk/app/visited/VisitedViewModel.kt
Outdated
Show resolved
Hide resolved
davidc-gds
force-pushed
the
GOVUKAPP-994_talkback_reads_out_wrong_item
branch
from
cf43c68 to
53945eb
Compare
gclssvglx
previously approved these changes
Dec 12, 2024
davidc-gds
previously approved these changes
Dec 12, 2024
gclssvglx
approved these changes
Dec 12, 2024
davidc-gds
approved these changes
Dec 12, 2024
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Talkback reads out wrong item
When selecting an item on PYV screen talkback reads out the wrong item
Resolution
JIRA ticket(s)
Figma
Video
GOVUKAPP-994.PYV.Talkback.Demo.mov