Previews check content type #4544
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- We're only ever interested in the first found value, so use #find instead of #select, check for nil? rather than empty?, and then we can remove all the #first calls in the templates.
- search engines contain some links to preview paths for assets that aren't previewable. Since we only allow previews for text/csv, we check the content_type of the attachment and return 404 if it doesn't match.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Return a 404 instead of the current broken page if a preview link is requested for a non-csv atttachment.
Why
Although we don't offer preview links to non-csv pages in gov.uk, some are in google search. We should return 404 so that they don't get into search / behave correctly when queried.
https://trello.com/c/bOxuUfBN/51-previews-for-non-csv-files
How
Add a check for content_type after getting the attachment metadata, then return a cacheable_404 if the content_type isn't "text/csv"
Screenshots
Before