Remove app-b prefixes from all components
#4539
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthillco
force-pushed
the
remove-app-b-class-names
branch
from
7246683 to
c4344e1
Compare
matthillco
force-pushed
the
remove-app-b-class-names
branch
from
c4344e1 to
5c3392e
Compare
matthillco
force-pushed
the
remove-app-b-class-names
branch
from
5c3392e to
dc64073
Compare
matthillco
added
github_actions
andysellick
reviewed
Dec 19, 2024
| @@ -5,32 +5,32 @@ describe('Main Menu Block module', function () { | |||
|
|
|||
| beforeEach(function () { | |||
| var DOM = | |||
| `<div class="app-b-main-nav" data-module="app-b-main-nav"> | |||
There was a problem hiding this comment.
Changes look fine, but the commit structure could be better - individually, each of these commits currently represents a breaking change. In future if the change warrants multiple commits I'd go block by block, but for simplicity now I'd suggest merging all the commits together.
There was a problem hiding this comment.
Good point, yeah these commits reflect my process to ensure I didn't miss anything. I've squashed them all into one commit now.
matthillco
force-pushed
the
remove-app-b-class-names
branch
from
dc64073 to
393e806
Compare
andysellick
approved these changes
Dec 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Remove the
app-b-prefix from all components.Why
This class naming convention was introduced early in the project as a way of namespacing blocks, but it serves no purpose and we haven’t consistently applied it to blocks, so it should be removed.
Trello