Remove subscribe app component
#4535
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The app level component is no longer required, it will be replaced with the button component from the govuk_publishing_components gem
The `icon-calendar` pngs can be deleted as they were only used by the `subscribe` component which will also be removed as part of this PR.
The `.app-c-subscribe` CSS class is no longer present following the removal of the subscribe app component. The test has been updated to get all links than end with the `.ics` file extension and check they have the correct data attributes set.
MartinJJones
force-pushed
the
remove-subscribe-app-component
branch
from
1292a29 to
6d45ab8
Compare
MartinJJones
changed the title
subscribe app component
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
icon-calendarPNG images, they were only used by the subscribe componentWhy
The subscribe component is not required in the application, the only difference between this component and a regular link is the inclusion of a calendar icon. The spacing and format of the icon is also inconsistent with other components where icons are used.
The text and style of the download will likely change in a future PR, but this will be dependant on translations and design changes.
Visual Changes
UK bank holidays
https://govuk-frontend-app-pr-4535.herokuapp.com/bank-holidays
When do the clocks change?
https://govuk-frontend-app-pr-4535.herokuapp.com/when-do-the-clocks-change
Trello card