Move es6-components.js back into application.js #4216
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MartinJJones
reviewed
Sep 6, 2024
There was a problem hiding this comment.
Nice work Ash, the changes look good to me.
Although it wouldn't break anything, please can we also remove the reference to the es6-components file in https://github.com/alphagov/frontend/blob/main/.nycrc#L14
AshGDS
force-pushed
the
type-module-cleanup
branch
from
fa8485c to
9971659
Compare
|
Thanks @MartinJJones - have done that now, so should be ready for another review 👍 |
MartinJJones
approved these changes
Sep 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What / Why
es6-components.jsback intoapplication.js, as the separation between the files is no longer needed now that IE11 is not supported.