-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Apply card component to homepage #4202
Conversation
45d6390
to
524ba5a
Compare
524ba5a
to
924d5f0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work on this Sonia, looks great on the homepage! :)
Just a couple of small comments on the indentation and how we can add the GA4 tracking to the "Service and information" section of the homepage
Replaced the bespoke homepage cards for Government Activity and Services & Information section with the card component from the gem, using the single-column layout.
924d5f0
to
eef30ec
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work, the changes look good to me 👍
What
Trello Card
Replaced the custom card component used for the homepage sections "Government Activity" and "Services and Information" with the standard card component from the components gem. This update uses the single-column layout to maintain the existing design.
Why
This change was made to remove the temporary styling that had been added to support the homepage redesign launched in 2023.
Screenshots
Deployment: https://govuk-frontend-app-pr-4202.herokuapp.com/
Services & Information section:
Mobile:
Tablet:
Laptop:
Government Activity section:
Mobile:
Tablet:
Laptop: