Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply card component to homepage #4202

Merged
merged 2 commits into from
Aug 29, 2024
Merged

Conversation

CodeSonia
Copy link
Contributor

@CodeSonia CodeSonia commented Aug 15, 2024

What

Trello Card

Replaced the custom card component used for the homepage sections "Government Activity" and "Services and Information" with the standard card component from the components gem. This update uses the single-column layout to maintain the existing design.

Why

This change was made to remove the temporary styling that had been added to support the homepage redesign launched in 2023.

Screenshots

Deployment: https://govuk-frontend-app-pr-4202.herokuapp.com/

Services & Information section:

Mobile:

Without Card Component With Card Component
image image

Tablet:

Without Card Component With Card Component
image image

Laptop:

Without Card Component With Card Component
image image

Government Activity section:

Mobile:

Without Card Component With Card Component
image image

Tablet:

Without Card Component With Card Component
image image

Laptop:

Without Card Component With Card Component
image image

@CodeSonia CodeSonia marked this pull request as draft August 15, 2024 13:45
@govuk-ci govuk-ci temporarily deployed to govuk-frontend-app-pr-4202 August 15, 2024 13:46 Inactive
@CodeSonia CodeSonia force-pushed the Apply-card-component-to-homepage branch from 45d6390 to 524ba5a Compare August 28, 2024 08:42
@govuk-ci govuk-ci temporarily deployed to govuk-frontend-app-pr-4202 August 28, 2024 08:43 Inactive
@CodeSonia CodeSonia force-pushed the Apply-card-component-to-homepage branch from 524ba5a to 924d5f0 Compare August 28, 2024 10:16
@govuk-ci govuk-ci temporarily deployed to govuk-frontend-app-pr-4202 August 28, 2024 10:17 Inactive
@CodeSonia CodeSonia changed the title [DO NOT MERGE] Apply card component to homepage Apply card component to homepage Aug 28, 2024
@CodeSonia CodeSonia marked this pull request as ready for review August 28, 2024 11:16
Copy link
Contributor

@MartinJJones MartinJJones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work on this Sonia, looks great on the homepage! :)

Just a couple of small comments on the indentation and how we can add the GA4 tracking to the "Service and information" section of the homepage

app/views/homepage/_services_and_information.html.erb Outdated Show resolved Hide resolved
app/views/homepage/_services_and_information.html.erb Outdated Show resolved Hide resolved
Replaced the bespoke homepage cards for Government Activity and Services & Information section with the card component from the gem, using the single-column layout.
@CodeSonia CodeSonia force-pushed the Apply-card-component-to-homepage branch from 924d5f0 to eef30ec Compare August 29, 2024 10:35
@govuk-ci govuk-ci temporarily deployed to govuk-frontend-app-pr-4202 August 29, 2024 10:35 Inactive
Copy link
Contributor

@MartinJJones MartinJJones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work, the changes look good to me 👍

@MartinJJones MartinJJones merged commit b84de09 into main Aug 29, 2024
12 checks passed
@MartinJJones MartinJJones deleted the Apply-card-component-to-homepage branch August 29, 2024 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants