Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix summer time date data #3817

Closed
wants to merge 2 commits into from
Closed

Conversation

me-and
Copy link

@me-and me-and commented Oct 19, 2023

The data for when the clocks go forward and back is incorrect. It displays correctly at https://www.gov.uk/when-do-the-clocks-change, but the errors are visible in the page metadata and at the generated API endpoint https://www.gov.uk/when-do-the-clocks-change.json.

I've removed the reference to specific years in the metadata – it doesn't seem to be necessary – and I've corrected the year in one of the entries.

It might be better if this data had more validation, and/or were generated programatically, but both of those seem like much more effort than I can spare right now.

@hannako
Copy link
Contributor

hannako commented Aug 16, 2024

Thanks for your PR, looks like this has been updated so I'll close.

@hannako hannako closed this Aug 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants