Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update font-sizes on mobile for the new homepage #3807

Merged
merged 1 commit into from
Oct 16, 2023

Conversation

MartinJJones
Copy link
Contributor

@MartinJJones MartinJJones commented Oct 13, 2023

What

Update the font-size on mobile for the new homepage so that body text is 19px and headings are 32px

Why

Required for the new homepage design

Trello card

Visual Changes

Mobile Before - New Homepage

Screenshot 2023-10-13 at 17 10 51

Mobile After - New Homepage

Screenshot 2023-10-13 at 17 08 20

⚠️ This repo is Continuously Deployed: make sure you follow the guidance ⚠️

@govuk-ci govuk-ci temporarily deployed to govuk-frontend-app-pr-3807 October 13, 2023 16:07 Inactive
Copy link
Contributor

@patrickpatrickpatrick patrickpatrickpatrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Updated the font-size on mobile for the new homepage so that body text is `19px` and headings are `32px`
@MartinJJones MartinJJones force-pushed the increase-font-size-mobile-new-homepage branch from d9e8a89 to a33e4a6 Compare October 16, 2023 10:49
@govuk-ci govuk-ci temporarily deployed to govuk-frontend-app-pr-3807 October 16, 2023 10:49 Inactive
@MartinJJones
Copy link
Contributor Author

MartinJJones commented Oct 16, 2023

The force push commit is to update the popular links heading for mobile screensizes on the new homepage design - https://github.com/alphagov/frontend/compare/d9e8a8959756add6532aac1f448e02bed30e1902..a33e4a613b1736de04a218aa9733d4632f977af7

@MartinJJones MartinJJones merged commit 6b41081 into main Oct 16, 2023
7 checks passed
@MartinJJones MartinJJones deleted the increase-font-size-mobile-new-homepage branch October 16, 2023 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants