Increase spacing on mobile for homepage #3801
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For the new homepage design, the total space on the left and right of the content should be `24px` for mobile, by adding 9px of padding to the required sections, we get a total of 24px (9px padding + 15px margin)
MartinJJones
force-pushed
the
increase-spacing-mobile-new-homepage
branch
from
bc071b5 to
edd4439
Compare
|
An intermediary step that's required for now but an elegant solution. Thanks Martin. |
patrickpatrickpatrick
approved these changes
Oct 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Increase the spacing on the left and right from
15pxto24pxfor mobile devices for the new homepage design.Why
For the new homepage design, the total space on the left and right of the content should be
24pxfor mobile.Trello card
Visual Changes
Before - Mobile
After - Mobile