GA4 homepage indexes #3784
Merged
GA4 homepage indexes #3784
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- each part of the homepage when tracked should include an index section (the index of the section) and an index section count (the total number of sections, currently 6) - sections were recently reordered, which caused the tracking to report incorrect numbers - restoring these numbers as partial variables passed from the main index template, to help highlight their existence and purpose
andysellick
requested review from
patrickpatrickpatrick,
hannalaakso and
hannako
andysellick
force-pushed
the
ga4-homepage-indexes
branch
from
b99c08b to
09c408f
Compare
andysellick
force-pushed
the
ga4-homepage-indexes
branch
from
09c408f to
0f716bb
Compare
patrickpatrickpatrick
approved these changes
Oct 2, 2023
AshGDS
approved these changes
Oct 2, 2023
- we recently modified the GA4 code so that we no longer have to mirror the structure of the GA4 schema when passing data via attributes, the JS identifies each attribute and places it in the correct place in the schema automatically
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Restore correct GA4 tracking indexes for six sections of the homepage.
This change includes some restructuring of the homepage partials, to aid with the visibility of the section parameters and to put them all in one place.
Why
Homepage tracking was not reporting correct indexes.
Visual changes
None.
Trello card: https://trello.com/c/1bYIU8oP/674-fix-any-issues-caused-by-homepage-changes-indexes