Fix for csv preview with legacy_url_path #3781
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richardTowers
approved these changes
Sep 29, 2023
syed-ali-tw
force-pushed
the
csv-preview-with-modern-url
branch
from
8b631c3 to
028bbe5
Compare
Reference issue:https://govuk.sentry.io/issues/4265154142/?alert_rule_id=3654813&alert_type=issue¬ification_uuid=8ab09d48-0416-4305-9e3c-0de49561a46a&project=202225&referrer=slack Currently content item when it returns attachments, it returns modern url hence when it tries to find for legacy url, it fails and @attachment_metadata is empty this cause @attachment_metadata.first to be nil and hence the error. With the fix we try to not rely on legacy_url_path, instead we look for the filename.
syed-ali-tw
force-pushed
the
csv-preview-with-modern-url
branch
from
028bbe5 to
35c07f7
Compare
richardTowers
approved these changes
Sep 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference issue:https://govuk.sentry.io/issues/4265154142/?alert_rule_id=3654813&alert_type=issue¬ification_uuid=8ab09d48-0416-4305-9e3c-0de49561a46a&project=202225&referrer=slack
Currently content item when it returns attachments, it returns modern url hence when it tries to find for legacy url, it fails and @attachment_metadata is empty this cause @attachment_metadata.first to be nil and hence the error.
With the fix we try to not rely on legacy_url_path, instead we look for the filename.