Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Ruby version #3778

Merged
merged 1 commit into from
Oct 2, 2023
Merged

Upgrade Ruby version #3778

merged 1 commit into from
Oct 2, 2023

Conversation

1pretz1
Copy link
Contributor

@1pretz1 1pretz1 commented Sep 28, 2023

Upgrades .ruby-version file which is used in Github CI and local
development.

Replaces the specified ruby version in the Gemfile from
.ruby-version file to a floating patch Ruby version (3.2.x). This has
the benefit of allowing patch versions of Ruby to be deployed by
updating the Ruby Docker image tag and rebuilding the app.

Trello:
https://trello.com/c/nKilDK4W/2198-dart-sass-upgrade-ruby-to-314-across-govuk-publishing-components-and-other-ux-apps

⚠️ This repo is Continuously Deployed: make sure you follow the guidance ⚠️

@govuk-ci govuk-ci temporarily deployed to govuk-frontend-app-pr-3778 September 28, 2023 12:33 Inactive
@1pretz1 1pretz1 force-pushed the upgrade-ruby-version branch from 08a8d9b to a92919b Compare September 28, 2023 12:47
@govuk-ci govuk-ci temporarily deployed to govuk-frontend-app-pr-3778 September 28, 2023 12:48 Inactive
@1pretz1 1pretz1 force-pushed the upgrade-ruby-version branch from a92919b to c1a2b2a Compare September 28, 2023 12:53
@govuk-ci govuk-ci temporarily deployed to govuk-frontend-app-pr-3778 September 28, 2023 12:53 Inactive
Upgrades `.ruby-version` file which is used in Github CI and local
development.

Replaces the specified `ruby` version in the Gemfile from
`.ruby-version` file to a floating patch Ruby version (3.2.x). This has
the benefit of allowing patch versions of Ruby to be deployed by
updating the Ruby Docker image tag and rebuilding the app.

Trello:
https://trello.com/c/nKilDK4W/2198-dart-sass-upgrade-ruby-to-314-across-govuk-publishing-components-and-other-ux-apps
@1pretz1 1pretz1 force-pushed the upgrade-ruby-version branch from c1a2b2a to 4ef8c1a Compare September 28, 2023 12:58
@govuk-ci govuk-ci temporarily deployed to govuk-frontend-app-pr-3778 September 28, 2023 12:58 Inactive
@1pretz1 1pretz1 marked this pull request as ready for review September 29, 2023 13:37
Copy link
Contributor

@KludgeKML KludgeKML left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@1pretz1 1pretz1 merged commit f92448d into main Oct 2, 2023
7 checks passed
@1pretz1 1pretz1 deleted the upgrade-ruby-version branch October 2, 2023 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants