Implement new header component for homepage #3776
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patrickpatrickpatrick
changed the title
patrickpatrickpatrick
force-pushed
the
use-new-homepage-header
branch
from
fb6f30c to
f2b4e66
Compare
patrickpatrickpatrick
force-pushed
the
use-new-homepage-header
branch
from
f2b4e66 to
987ee83
Compare
patrickpatrickpatrick
force-pushed
the
use-new-homepage-header
branch
from
987ee83 to
d1bdf2f
Compare
patrickpatrickpatrick
force-pushed
the
use-new-homepage-header
branch
from
00912eb to
4904f9c
Compare
patrickpatrickpatrick
force-pushed
the
use-new-homepage-header
branch
from
4904f9c to
8b16ea5
Compare
patrickpatrickpatrick
force-pushed
the
use-new-homepage-header
branch
from
8b16ea5 to
67db8c5
Compare
patrickpatrickpatrick
force-pushed
the
use-new-homepage-header
branch
from
67db8c5 to
acfc643
Compare
patrickpatrickpatrick
force-pushed
the
use-new-homepage-header
branch
from
acfc643 to
30bed87
Compare
MartinJJones
reviewed
Oct 2, 2023
|
|
||
| $pale-blue-colour: #d2e2f1; | ||
|
|
||
| .app-c-homepage-header { |
There was a problem hiding this comment.
Now that this has moved back to a view template, I think we should be able to remove the app-c- prefix from the class names.
| add_view_stylesheet("homepage_header") | ||
| %> | ||
|
|
||
| <header class="app-c-homepage-header"> |
There was a problem hiding this comment.
We would also need to update this template to remove the app-c- prefixes in the class names
patrickpatrickpatrick
force-pushed
the
use-new-homepage-header
branch
from
30bed87 to
00ac52d
Compare
MartinJJones
approved these changes
Oct 3, 2023
Move the inverse_header to a seperate partial. Implement the new homepage_header as a seperate partial. Add logic for toggling the new header on and off using the `new_design` url parameter.
patrickpatrickpatrick
force-pushed
the
use-new-homepage-header
branch
from
00ac52d to
bf131a0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Move the 'inverse-header' component to the components folder. Make a new 'homepage-header' component. Add logic for displaying the 'inverse-header' when
new_designparameter is not present. Add logic displaying for displaying the 'homepage-header' whennew_designparameter is present.Why
This is part of changes that will be gradually rolled out to the homepage. As these changes are not going to be made live immediately, I have attempted to split the code in a way that will allow them to be easily toggled by the
new_designparameter. The additional effect is that this makes the code easier to understand and will allow us to easily make the change to the header permanent.Visual Difference
with
/new_design=trueRelevant Trello Card