Change layout of homepage #3743
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patrickpatrickpatrick
force-pushed
the
change-layout-of-homepage
branch
from
7165494 to
0441368
Compare
patrickpatrickpatrick
force-pushed
the
change-layout-of-homepage
branch
from
0441368 to
4b7fdc5
Compare
patrickpatrickpatrick
force-pushed
the
change-layout-of-homepage
branch
from
4b7fdc5 to
169e57a
Compare
patrickpatrickpatrick
force-pushed
the
change-layout-of-homepage
branch
from
169e57a to
6207687
Compare
patrickpatrickpatrick
changed the title
patrickpatrickpatrick
force-pushed
the
change-layout-of-homepage
branch
from
6207687 to
573bcf6
Compare
patrickpatrickpatrick
force-pushed
the
change-layout-of-homepage
branch
from
573bcf6 to
ab3f8f1
Compare
patrickpatrickpatrick
force-pushed
the
change-layout-of-homepage
branch
from
ab3f8f1 to
21d89da
Compare
patrickpatrickpatrick
force-pushed
the
change-layout-of-homepage
branch
from
21d89da to
ff075b5
Compare
patrickpatrickpatrick
force-pushed
the
change-layout-of-homepage
branch
from
ff075b5 to
92f7dc3
Compare
patrickpatrickpatrick
changed the title
patrickpatrickpatrick
force-pushed
the
change-layout-of-homepage
branch
from
fa35c9c to
79d40c9
Compare
hannako
reviewed
Sep 18, 2023
hannalaakso
reviewed
Sep 19, 2023
MartinJJones
force-pushed
the
change-layout-of-homepage
branch
from
57526f0 to
098aafc
Compare
The CSS is used for the grid is taken from the `cards` component.
MartinJJones
force-pushed
the
change-layout-of-homepage
branch
from
098aafc to
42ccdc7
Compare
hannalaakso
approved these changes
Sep 21, 2023
There was a problem hiding this comment.
Great, thanks both @MartinJJones and @patrickpatrickpatrick for getting this into such a good place 🙌 We should probably now update the PR description as it's now longer reflective of the work, there have been quite a few design changes since.
I tested the page on the browsers and devices we usually test in. Didn't spot any issues, apart from how on mobile there seems to be a bit too much grey space below the Popular links. I checked with Monica who agreed that we should reduce the amount of space so that's something to look at tomorrow.
I'm giving this PR a tick to indicate that I'm happy with everything apart from the above mobile spacing issue so whoever reviews the PR tomorrow can focus on reviewing any small fixes we add tomorrow.
hannalaakso
changed the title
MartinJJones
force-pushed
the
change-layout-of-homepage
branch
from
a7477d4 to
116017c
Compare
|
@hannalaakso thanks for finding and reporting the spacing issue on mobile, I've fixed this issue on a recent commit: 
|
- Ensures that the total padding-bottom on desktop underneath Popular links is 50px (30px + 20px from the popular links) - Removed grid-auto-rows: fraction(1) as it is not required
MartinJJones
force-pushed
the
change-layout-of-homepage
branch
from
116017c to
ba43a98
Compare
MartinJJones
force-pushed
the
change-layout-of-homepage
branch
from
ba43a98 to
d0dd87f
Compare
MartinJJones
force-pushed
the
change-layout-of-homepage
branch
from
553599a to
1feee47
Compare
Temp style overrides to the image card component from the gem to: - Ensure the space between the image card and the text remains at 15px on mobile, this was previously 30px on mobile. - Ensure the featured image cards have 15px padding to the left and right when this screen width is =< 319px.
MartinJJones
force-pushed
the
change-layout-of-homepage
branch
from
1feee47 to
4363b40
Compare
|
I've also completed a secondary review of changes made today and it looks good to go. |
MartinJJones
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Change the layout of homepage so that:
Why
As part of several incremental changes being made to the homepage.
Trello Card
Visual Changes
Before
After