Merge pull request #3767 from alphagov/ga4-fix

Change GA4 type from licence to licence transaction
alphagov · Sep 18, 2023 · dc07cb0 · dc07cb0
2 parents 563672a + ce700c7
commit dc07cb0
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/app/views/licence_transaction/_licensify_unavailable.html.erb b/app/views/licence_transaction/_licensify_unavailable.html.erb
@@ -1,7 +1,7 @@
 <%
   ga4_attributes = {
     event_name: "form complete",
-    type: "licence",
+    type: content_item_hash["document_type"].gsub("_", " "),
     text: "You cannot apply for this licence online",
     action: "complete",
     tool_name: publication.title,

diff --git a/test/integration/licence_transaction_test.rb b/test/integration/licence_transaction_test.rb
@@ -830,7 +830,7 @@ class LicenceTransactionTest < ActionDispatch::IntegrationTest
       expected_data_module = "ga4-auto-tracker"
 
       ga4_auto_attribute = page.find("div[data-ga4-auto]")["data-ga4-auto"]
-      ga4_expected_object = "{\"event_name\":\"form complete\",\"type\":\"licence\",\"text\":\"You cannot apply for this licence online\",\"action\":\"complete\",\"tool_name\":\"Licence to kill\"}"
+      ga4_expected_object = "{\"event_name\":\"form complete\",\"type\":\"licence transaction\",\"text\":\"You cannot apply for this licence online\",\"action\":\"complete\",\"tool_name\":\"Licence to kill\"}"
 
       assert_equal expected_data_module, data_module
       assert_equal ga4_expected_object, ga4_auto_attribute