Address accessibility issues raised by Sitemorse report #1113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
pixeltrix
commented
Dec 23, 2024
pixeltrix
commented
- Fix invalid nesting of tags
- Use HTML5 void elements instead of empty element tags
- Remove legacy IE code
- Add meta description
- Improve contrast
- Improve accessibility of links
- Remove unnecessary role attributes
- Add missing headings
- Don't use section elements without headings
This is the recommended default Rails docker setup and it allows us to add processes for CSS/JS bundling when we switch away from sprockets.
pixeltrix
force-pushed
the
address-accessibility-issues
branch
from
fb43815 to
49b0ea2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.