CI - Prover Performance metric fix - 2

[MdTeach]

Description

Type of Change

• Bug fix (non-breaking change which fixes an issue)
• New feature/Enhancement (non-breaking change which adds functionality or enhances an existing one)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• Documentation update
• Refactor
• New or updated tests
• Dependency Update

Notes to Reviewers

Checklist

• I have performed a self-review of my code.
• I have commented my code where necessary.
• I have updated the documentation if needed.
• My changes do not introduce new warnings.
• I have added tests that prove my changes are effective or that my feature works.
• New and existing tests pass with my changes.

Related Issues

[codecov]

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Project coverage is 56.50%. Comparing base (7b9d76c) to head (e2a15f4).
Report is 3 commits behind head on main.

Files with missing lines	Patch %	Lines
provers/perf/src/main.rs	0.00%	4 Missing ⚠️

@@           Coverage Diff           @@
##             main     #584   +/-   ##
=======================================
  Coverage   56.50%   56.50%           
=======================================
  Files         314      316    +2     
  Lines       31957    31983   +26     
=======================================
+ Hits        18057    18073   +16     
- Misses      13900    13910   +10     

Files with missing lines	Coverage Δ
provers/perf/src/main.rs	0.00% <0.00%> (ø)

... and 24 files with indirect coverage changes

[github-actions]

Commit: 292bdb9

SP1 Performance Test Results

program	cycles	success
BTC_BLOCKSPACE	7,251,326	✅
EL_BLOCK	100,761	✅
CL_BLOCK	55,512	✅
L1_BATCH	23,221	✅
L2_BATCH	11,446	✅
CHECKPOINT	16,119	✅

[storopoli]

Do you think is possible to save the "mustached" stuff ${{ foo.BAR }} in an env then use that env instead in

strata/.github/workflows/prover.yml

Lines 52 to 61 in e2a15f4

	- name: Run performance evaluation
	run: |
	cargo run --profile prover-ci -- \
	--post-to-gh \
	--github-token "${{ secrets.GITHUB_TOKEN }}" \
	--pr-number "${{ github.event.pull_request.number }}" \
	--commit-hash "${{ github.sha }}" \
	working-directory: provers/perf
	env:
	RUSTFLAGS: "-C target-cpu=native -C link-arg=-fuse-ld=lld"

We use that in

strata/.github/workflows/cron-nightly-rust.yml

Lines 48 to 57 in de7ffbb

	env:
	NIGHTLY_DATE: ${{ env.nightly_date }}
	with:
	author: Update Nightly Rustc Bot <[email protected]>
	committer: Update Nightly Rustc Bot <[email protected]>
	title: Automated update to rustc (to nightly-$NIGHTLY_DATE)
	body: |
	Automated update to Rust nightly by [create-pull-request](https://github.com/peter-evans/create-pull-request) GitHub action
	commit-message: Automated update to Rust nightly-$NIGHTLY_DATE
	branch: create-pull-request/automated-nightly-update

This will greatly reduce the command injection attack surface.

See https://woodruffw.github.io/zizmor/audits/#template-injection