-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
STR-734: OPERATOR REASSIGNMENT #557
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAttention: Patch coverage is
@@ Coverage Diff @@
## main #557 +/- ##
==========================================
- Coverage 56.64% 56.55% -0.09%
==========================================
Files 314 314
Lines 31896 31940 +44
==========================================
- Hits 18066 18063 -3
- Misses 13830 13877 +47
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we should create a proper parent class for tests that needs withdrawal/deposits that can have all the yet-to-move utils.py
functions that I commented below in the NITs.
Then all the DRT, get balances, withdraw etc functionality is encapsulated in it and we can create proper concrete classes for the other tests that inherit from this parent class.
Sorry to push all this refactoring into your plate.
Since you're already editing these files it is convenient.
However, feel free to reject and open a ticket for this so that we can do it later.
I think it's reasonable to include the fix for this ticket in this PR too, since it's all related. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some final nits and a question.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK 5eeff36
func-test: add bridge withdraw reassignment bridge-client: add timeout for duties bridge-client: add duty_timeout_duration chaintsn: STR-781 fix reassignment bug func-test: add new BridgeTestBase for bridge related tests resolve comments
5eeff36
to
984b8ad
Compare
Description
Functional test where we make deposits, then trigger the withdrawal. client associated with assigned operator id is stopped. We produce l1 blocks so that the dispatch assignment duration is over, and later check if new operator is being assigned or not
Type of Change
Notes to Reviewers
Checklist
Related Issues
STR-734