Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Str-796: ZkVMs prover performance metrics #555

Merged
merged 26 commits into from
Dec 30, 2024

Conversation

evgenyzdanovich
Copy link
Contributor

@evgenyzdanovich evgenyzdanovich commented Dec 20, 2024

Description

Introduce performance metrics for provers. Currently, only displays cycle_count for each ZkVm program.

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature/Enhancement (non-breaking change which adds functionality or enhances an existing one)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Refactor
  • New or updated tests
  • Dependency Update

Notes to Reviewers

Checklist

  • I have performed a self-review of my code.
  • I have commented my code where necessary.
  • I have updated the documentation if needed.
  • My changes do not introduce new warnings.
  • I have added tests that prove my changes are effective or that my feature works.
  • New and existing tests pass with my changes.

Related Issues

STR-796

@evgenyzdanovich evgenyzdanovich force-pushed the str-651-prover-perf-metrics branch 2 times, most recently from 8678982 to ab3a143 Compare December 20, 2024 22:56
Copy link

github-actions bot commented Dec 20, 2024

Commit: 6d00b87

SP1 Performance Test Results

program cycles success
BTC_BLOCKSPACE 7251269
EL_BLOCK 100761
CL_BLOCK 55522
L1_BATCH 23221
L2_BATCH 11446
CHECKPOINT 16119

@evgenyzdanovich evgenyzdanovich force-pushed the str-651-prover-perf-metrics branch 3 times, most recently from 22bf968 to 7fa7b51 Compare December 22, 2024 19:42
@evgenyzdanovich evgenyzdanovich force-pushed the str-651-prover-perf-metrics branch 5 times, most recently from 9a9e327 to be6eda1 Compare December 23, 2024 12:40
@evgenyzdanovich evgenyzdanovich force-pushed the str-651-prover-perf-metrics branch from 3e65726 to 18ef0fa Compare December 24, 2024 09:45
@evgenyzdanovich evgenyzdanovich changed the title Str-651: [DRAFT][DO NOT MERGE][UNDER TESTING][WIP] ZkVMs prover performance metrics Str-651: ZkVMs prover performance metrics Dec 24, 2024
@evgenyzdanovich evgenyzdanovich force-pushed the str-651-prover-perf-metrics branch from de1a8cf to 8c8a9c4 Compare December 24, 2024 16:02
@evgenyzdanovich evgenyzdanovich force-pushed the str-651-prover-perf-metrics branch from 8c8a9c4 to a58c1a5 Compare December 24, 2024 17:18
Copy link

codecov bot commented Dec 24, 2024

Codecov Report

Attention: Patch coverage is 1.28755% with 230 lines in your changes missing coverage. Please review.

Project coverage is 56.60%. Comparing base (506fd5c) to head (eee2e9c).
Report is 7 commits behind head on main.

Files with missing lines Patch % Lines
provers/perf/src/main.rs 0.00% 195 Missing ⚠️
provers/perf/src/lib.rs 0.00% 15 Missing ⚠️
provers/perf/src/reports.rs 0.00% 11 Missing ⚠️
crates/zkvm/adapters/risc0/src/host.rs 0.00% 3 Missing ⚠️
crates/zkvm/adapters/sp1/src/host.rs 0.00% 3 Missing ⚠️
crates/zkvm/hosts/src/lib.rs 50.00% 3 Missing ⚠️
@@            Coverage Diff             @@
##             main     #555      +/-   ##
==========================================
- Coverage   57.33%   56.60%   -0.74%     
==========================================
  Files         309      315       +6     
  Lines       31510    31913     +403     
==========================================
- Hits        18067    18063       -4     
- Misses      13443    13850     +407     
Files with missing lines Coverage Δ
crates/zkvm/adapters/native/src/host.rs 74.07% <ø> (+15.25%) ⬆️
crates/zkvm/zkvm/src/host.rs 100.00% <ø> (ø)
crates/zkvm/zkvm/src/proof.rs 53.19% <ø> (ø)
crates/zkvm/zkvm/src/prover.rs 100.00% <ø> (+39.13%) ⬆️
crates/zkvm/adapters/risc0/src/host.rs 0.00% <0.00%> (ø)
crates/zkvm/adapters/sp1/src/host.rs 0.00% <0.00%> (ø)
crates/zkvm/hosts/src/lib.rs 50.00% <50.00%> (ø)
provers/perf/src/reports.rs 0.00% <0.00%> (ø)
provers/perf/src/lib.rs 0.00% <0.00%> (ø)
provers/perf/src/main.rs 0.00% <0.00%> (ø)

... and 5 files with indirect coverage changes

@evgenyzdanovich evgenyzdanovich force-pushed the str-651-prover-perf-metrics branch from 07fd3a6 to eee2e9c Compare December 24, 2024 19:06
@evgenyzdanovich evgenyzdanovich marked this pull request as ready for review December 24, 2024 19:14
@evgenyzdanovich evgenyzdanovich requested review from a team as code owners December 24, 2024 19:14
@john-light john-light changed the title Str-651: ZkVMs prover performance metrics Str-796: ZkVMs prover performance metrics Dec 25, 2024
Copy link
Contributor

@delbonis delbonis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved but still maybe pending some action about what's discussed in that thread?

@evgenyzdanovich
Copy link
Contributor Author

@delbonis thanks! I'll discuss with Prajwol to make sure we are on the same page and resolve the conversation/make necessary adjustments.

I'll ping you to reapprove in case there were some changes required

Copy link
Contributor

@prajwolrg prajwolrg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is good to merge. We can revisit the discussion when we decide to update standalone zkvm repo and use it here.

@evgenyzdanovich evgenyzdanovich added this pull request to the merge queue Dec 30, 2024
Merged via the queue into main with commit d64bbe2 Dec 30, 2024
18 of 19 checks passed
@evgenyzdanovich evgenyzdanovich deleted the str-651-prover-perf-metrics branch December 30, 2024 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants