-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Str-796: ZkVMs prover performance metrics #555
Conversation
8678982
to
ab3a143
Compare
Commit: 6d00b87 SP1 Performance Test Results
|
22bf968
to
7fa7b51
Compare
9a9e327
to
be6eda1
Compare
3e65726
to
18ef0fa
Compare
de1a8cf
to
8c8a9c4
Compare
8c8a9c4
to
a58c1a5
Compare
Codecov ReportAttention: Patch coverage is
@@ Coverage Diff @@
## main #555 +/- ##
==========================================
- Coverage 57.33% 56.60% -0.74%
==========================================
Files 309 315 +6
Lines 31510 31913 +403
==========================================
- Hits 18067 18063 -4
- Misses 13443 13850 +407
|
… by mistake during feature reshuffling.
07fd3a6
to
eee2e9c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved but still maybe pending some action about what's discussed in that thread?
@delbonis thanks! I'll discuss with Prajwol to make sure we are on the same page and resolve the conversation/make necessary adjustments. I'll ping you to reapprove in case there were some changes required |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is good to merge. We can revisit the discussion when we decide to update standalone zkvm repo and use it here.
Description
Introduce performance metrics for provers. Currently, only displays
cycle_count
for each ZkVm program.Type of Change
Notes to Reviewers
Checklist
Related Issues
STR-796