#441 - Fix exit code 1 if Harmony patching failled

[TonEnfer]

#441 - Fix exit code 1 if Harmony patching failled - use LogWarning instead LogError

Additionally, the code style has been changed - filescoped namespace, explicit modifiers for better code readability

Context

Checklist

• Sign Allure CLA
• Provide unit tests

[delatrie]

Hi, @TonEnfer! Thank you again for your contribution.

The log level change is solid.
I have mixed feelings about the code style changes, though.

• File-scope namespaces - awesome! All new language features of C# up through version 10 are welcome.
• Explicit private modifiers - I personally don't see much value in them, but ok, let's use them.

What bothers me are underscore prefixes. I see some value in prefixing class variables as that helps distinguish between local/class variables (although I'm not a big fan of it either). But I don't particularly like prefixing private functions and camel-casing them for the following considerations:

• If I call a function from inside the class, I don't care much about whether it is private. From the outside, private functions aren't visible at all, aren't shown by IntelliSense (or other autocompletion tools), and yield the compiler error when called. Prefixes don't help us here in any way. They are more like hacks from the JavaScript world, where you have no visibility modifiers.
• Tying a function's name to its visibility forces you to make more changes when you change the visibility (unlike class variables, functions' visibility changes more often).
• We follow Pascal Casing for all functions in the code base (it's pretty standard in the .NET world)

If you have any thoughts about why we should add prefixes to functions, I would gladly read them. Otherwise, please revert the corresponding changes.

[delatrie]

Looks good, thank you!